Fix review findings immersed in #2520#2521
Closed
Pankraz76 wants to merge 13 commits intodiffplug:mainfrom
Closed
Conversation
added 11 commits
June 23, 2025 22:09
# Conflicts: # lib/src/test/java/com/diffplug/spotless/pom/SortPomCfgTest.java
# Conflicts: # lib/src/test/java/com/diffplug/spotless/pom/SortPomCfgTest.java
Author
|
item: |
Author
|
plz disalbe me for auto build im discovering first then extract dedicated parts. |
Pankraz76
commented
Jun 24, 2025
| } | ||
|
|
||
| private static String getDefaultLineSeparator() { | ||
| return System.getProperty("line.separator", "\n"); |
Author
There was a problem hiding this comment.
feature envy, reimplementing java.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| final String comment = token.getString(); | ||
| final String withoutTrailingWhitespace = comment.replaceFirst("\\s*$", ""); | ||
| token.setString(withoutTrailingWhitespace); | ||
| token.setString(token.getString().replaceFirst("\\s*$", "")); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
Author
There was a problem hiding this comment.
might be, logic is same as before. Just the field burden imposing coupling was inlined to avoid boilerplate. So only removed the documentation overhead in favor of 1 LOC concise possible statement.
Pankraz76
commented
Jun 24, 2025
|
|
||
| final String comment = token.getString(); | ||
| final String withoutTrailingWhitespace = comment.replaceFirst("\\s*$", ""); | ||
| token.setString(withoutTrailingWhitespace); |
Author
There was a problem hiding this comment.
Pankraz76
commented
Jun 24, 2025
| if (functionBracket.contains(Boolean.TRUE)) | ||
| return 0; | ||
| try { | ||
| final String defaultLineSeparator = getDefaultLineSeparator(); |
Pankraz76
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.
Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)